Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update summarize_barrnap.py #716

Closed
wants to merge 1 commit into from
Closed

Update summarize_barrnap.py #716

wants to merge 1 commit into from
+5 −2

Conversation

vaulot
Copy link
Contributor

@vaulot vaulot commented Mar 22, 2024

When several genes are identified by barrnap, retains the lowest e-value

PR checklist

  • [x ] This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@vaulot
Update summarize_barrnap.py
2617420 
When several genes are identified by barrnap, retains the lowest e-value
@github-actions GitHub Actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @vaulot,

It looks like this pull-request is has been made against the vaulot/ampliseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the vaulot/ampliseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@vaulot vaulot changed the base branch from master to dev March 22, 2024 12:33
@d4straub
Copy link
Collaborator

Thanks for the PR!
However, the changes are based on the master branch, which represents the code from the most recent release. The latest development version is the dev branch. Therefore that PR fails on all that CI tests. Changes in nf-core pipelines should be always done based on the dev branch and then a PR against dev opened. The master branch is only to be touched for releases of the pipeline. Would you like to make an updated PR?

@vaulot
Copy link
Contributor Author

vaulot commented Mar 25, 2024

Yop
Sorry for that, I will do a pull request on dev branch. Cheers. Daniel

@vaulot vaulot closed this by deleting the head repository Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaulot @d4straub